Skip to content

fix(build): time client, server and nitro from Vite's own bundles - #1650

Closed
onmax wants to merge 1 commit into
nuxt:mainfrom
onmax:fix/build-progress-nuxt5
Closed

fix(build): time client, server and nitro from Vite's own bundles#1650
onmax wants to merge 1 commit into
nuxt:mainfrom
onmax:fix/build-progress-nuxt5

Conversation

@onmax

@onmax onmax commented Nov 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

nuxt build charged almost all the bundling to nitro: a one-file nuxt 5 app reported client 10ms · server 12ms · nitro 872ms. vite resolves every environment's config before bundling anything, and nitro:build:before fires while nitro's config resolves, so we entered the nitro phase a few ms in.

this adds a small vite plugin from vite:extend and moves between phases on vite's own buildStart and closeBundle hooks, so client, server and nitro each get their own time. it also drops the experimental.viteEnvironmentApi check and its single Bundling app phase.

@onmax
onmax requested a review from danielroe as a code owner November 1, 2026 11:12
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

We're closing this for now as the account looks automated. If we got that wrong, please just reopen the PR and we'll take another look.

@github-actions github-actions Bot changed the title fix(build): time client, server and nitro from Vite's own bundles 🚨 unwelcome pr from bot 🚨 Nov 1, 2026
@github-actions github-actions Bot closed this Nov 1, 2026
@onmax onmax mentioned this pull request Nov 1, 2026
Open
@codecov-commenter

codecov-commenter commented Nov 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@cd8f364). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1650   +/-   ##
=======================================
  Coverage        ?   84.58%           
=======================================
  Files           ?      183           
  Lines           ?    11804           
  Branches        ?     3381           
=======================================
  Hits            ?     9985           
  Misses          ?     1532           
  Partials        ?      287

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Nov 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 2 untouched benchmarks

Comparing onmax:fix/build-progress-nuxt5 (04d1b38) with main (cd8f364)

Open in CodSpeed

@onmax

onmax commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

hey @danielroe , sorry for bothering again, but this PR was autoclosed

@onmax onmax changed the title 🚨 unwelcome pr from bot 🚨 fix(build): time client, server and nitro from Vite's own bundles Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe Awaiting requested review from danielroe danielroe is a code owner

Assignees

No one assigned

Labels

possible bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onmax @codecov-commenter